Andreas Gullberg Larsen

Results 259 comments of Andreas Gullberg Larsen

@AlexC84 You are not wrong, but as outlined in the top post and in the discussions of the issues it links to, I believe it comes down to what people...

Nice, a third option, this keeps getting better 😆 I have don't have any strong opinions on this myself, I think it's fine as it is. I don't see a...

@mostanes Interesting, are you saying that these operations don't make sense to you? Honest question. LINQPad ```c# var temp20C = Temperature.FromDegreesCelsius(20); var tempDelta5C = TemperatureDelta.FromDegreesCelsius(5); Temperature temp25C = temp20C +...

Thanks for the details. > This is a bad idea (thought experiment: why would degrees celsisus -> temperature delta be different from degrees celsius -> kelvins -> temperature delta?) I'm...

Thanks for the reference. I am not familiar with OM ontology, but this is absolutely interesting knowledge to lean on. I don't immediately see how to apply this information, but...

I think this looks pretty good. Just some loose questions/comments above. @tmilnthorp you were involved in #717 too, maybe take a look when you have the time?

I tried to refresh my memory by looking back at the comments. I think for me, the only think I'm still unsure about is the hard coded constant of `5`....

I agree it sounds like the safest option. I still don't feel this equality is all that useful though, for any non-trivial unit conversion there will be loss of precision...

Good point. Changing equality from base unit to value+unit would break things like Zero comparison, I hadn't thought of that. So. Hm. Actually. I think we should honor this contract,...

Thanks, I got the notification yesterday that the LFS _bandwidth_ of 1 GB was used up, 1.5 had been used. Storage was fine. I guess the repo is being checked...