Andreas Gullberg Larsen

Results 259 comments of Andreas Gullberg Larsen

I hear your pain @dschuermans 😅 This discussion has literally gone for years, on and off. I think the reasoning is best outlined in this comment https://github.com/angularsen/UnitsNet/issues/1017#issuecomment-1024605778 I simply don't...

Thank you for the comments and suggestions. > 2 separate packages of UnitsNet I don't like this option. It will confuse people what package to choose, and it complicates transient...

Some other options not mentioned: - For comparison methods on collections, you can pass `IEqualityComparer` to provide your own equality comparers. UnitsNet could maybe provide some default instances based on...

The current discussion seems to have met a dead end, I propose to move ahead with the strict equality change and rather discuss any ideas for global configuration in a...

Sorry for the late reply, I have been missing out on email notifications for some time and also been very busy. Will review soon.

Yes that's right. It only has an effect at compile time. Also, it is an optional feature that consumers of the nuget will have to enable in their projects to...

Keeping this one up for a bit in case someone wants to pick it up and run with it.

I think in general it is not a good idea to tamper with global static variables in a library. If you're using another library or project that also depend on...

In quantities like `Length`, rename the property `BaseUnit` to `DefaultUnit` or `IntermediateUnit` to avoid confusion with the new `BaseUnits` per unit, since both are defined in JSON. Also update the...

Change all `string culture` parameters to to `IFormatProvider`. Example `UnitConverter`: https://github.com/angularsen/UnitsNet/blob/c4cab69eaab141094462e1ad66bca94d38fbce31/UnitsNet/UnitConverter.cs#L214