Andreas Gullberg Larsen

Results 259 comments of Andreas Gullberg Larsen

Will get to this, just a bit short on time these days.

I was not able to push a change, so here is the diff I tried to push regarding As() overloads: [0001-Simplify-As-overloads-by-reusing-and-casting-to-doub.patch.txt](https://github.com/angularsen/UnitsNet/files/8749533/0001-Simplify-As-overloads-by-reusing-and-casting-to-doub.patch.txt)

On the phone, but we can't make breaking changes in v4. Either we must fix it or move this change to v5 branch.

Aha, my bad. `UnitsNetJsonConverter` seems already removed in v5 branch, but it seems the backwards compatibility tests are failing on it. I find that odd, I thought those tests solely...

I just removed the compatibility tests from release/v5 and merged it into here, I agree they no longer serve a purpose. 142a1fb - 🔥 Remove UnitsNet.Serialization.JsonNet.CompatibilityTests

Sorry for late reply, I've been missing out on some email notifications on this repo lately. I'll need to revisit this and refresh my brain on it, will get back...

Thanks for reporting, you may be right. Will look into it.

@pgrawehr There is #982 now. Would you be interested in doing a PR to that branch?

@dschuermans I implemented strict equality, if you want to look over it. Based on decision in https://github.com/angularsen/UnitsNet/issues/1017#issuecomment-1028402841.

> > @dschuermans I implemented strict equality, if you want to look over it. > > Based on decision in [#1017 (comment)](https://github.com/angularsen/UnitsNet/issues/1017#issuecomment-1028402841). > > Nice, > > But if I...