Andreas Gullberg Larsen

Results 322 comments of Andreas Gullberg Larsen

Without fully groking the full context here, I _think_ solution 1 feels natural? I'm fine either way as long as there is a comment next to it explaining why.

Nr2 seems the most straight forward though, but I was puzzled by `relation.RightQuantity.Name`, should it not be LeftQuantity? Was the operands swapped before this?

I am a little hesitant to add this, it feels too domain specific and I can't find much on this particular quantity on Google. UnitsNet already has S, and google...

Thanks for reporting back 👍

100k lines removed, 100k lines added 🙈 ![image](https://github.com/user-attachments/assets/b600c4ac-ce3c-4417-9171-a9b9782d88f1)

Ok, I'm not going to get through a review of this many files anytime soon. Maybe we should have a screen sharing session and go through it together. I may...

Ok, sounds good. Just send PRs my way and I'll try to get to them. I have a little bit of extra time this weekend.

Great! I may have some time this weekend to look at it.

With #1543 there should be a new `EnumHelper` marked `internal`, can you reuse that? Otherwise, for tests just add whatever you need, no big deal.

@lipchev I really like the concept of the decimal fractions, it solves equality issues and precision, and if I recall correctly it remains fairly backwards compatible. I want to say...