Andreas Gullberg Larsen
Andreas Gullberg Larsen
@tmilnthorp I took a look, merged in latest `master` and tried to fix a bunch of compile errors. - Add `struct` generic constraint to T - Add GenericNumberHelper for MinValue,...
@tmilnthorp @lipchev The V5 release branch is rolling. If there is anything you are eager to include/remove, then please give a heads up here. I hope to make this release...
@ebfortin Thanks, could you please report back with the exact error and what you would expect instead? There are many breaking changes in v5, but if you found something that...
@ebfortin Right, it's in the breaking changes list. > Remove IEquatable and equality operators/methods The reasoning is that comparing equality of two quantities should use the `Equals()` methods, where you...
> I think `UnitSystem` can go, but `BaseDimensions` and `BaseUnits` are useful and I'd like to see them stay Thanks, that is useful to know. I am open to keep...
Added a TODO: Add back `IEquatable`, but implement as strict equality with tuple of quantity name + unit + value. https://github.com/angularsen/UnitsNet/issues/1017#issuecomment-1028401955
@tmilnthorp What do you think about this? > If we keep them, how about renaming them to SiBaseDimensions and SiBaseUnits? Primarily want to distinguish from Length.BaseUnit and "BaseUnit" in JSON....
> I wonder if we should name `Length.BaseUnit` something like `ReferenceUnit` Yes, I initially tried ConversionBaseUnit, but it's just cumbersome and long so I reverted it. ReferenceUnit is a decent...
I think the main argument for not supporting NaN and Infinity, is that decimal does not support it. So it would be inconsistent across different quantities.
I see your point, but I do think that very few consumers of UnitsNet know anything about the whole double vs decimal dilemma we are currently at. So I do...