UnitsNet icon indicating copy to clipboard operation
UnitsNet copied to clipboard

AreaDensity: Add g/m2, mg/m2, add operators

Open Brunni opened this issue 2 years ago • 2 comments

Fixes #1131

Brunni avatar Sep 02 '22 19:09 Brunni

Codecov Report

Merging #1134 (8a9398a) into master (77b1ef2) will increase coverage by 0%. The diff coverage is 80%.

:exclamation: Current head 8a9398a differs from pull request most recent head 39f271e. Consider uploading reports for the commit 39f271e to get more accurate results

@@          Coverage Diff           @@
##           master   #1134   +/-   ##
======================================
  Coverage      85%     85%           
======================================
  Files         322     323    +1     
  Lines       52322   52353   +31     
======================================
+ Hits        44894   44929   +35     
+ Misses       7428    7424    -4     
Impacted Files Coverage Δ
...nitsNet/CustomCode/Quantities/AreaDensity.extra.cs 0% <0%> (ø)
UnitsNet/CustomCode/Quantities/Mass.extra.cs 89% <50%> (-5%) :arrow_down:
...s/GeneratedCode/NumberToAreaDensityExtensions.g.cs 100% <100%> (ø)
UnitsNet/GeneratedCode/Quantities/AreaDensity.g.cs 82% <100%> (+4%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 02 '22 20:09 codecov[bot]

The build reached maximum of 60 Minutes. Can someone restart it?

EDIT: Build seems to be normally at 58 Minutes. This is quite long. How does it come?

Brunni avatar Sep 11 '22 08:09 Brunni

Sorry for the late reply, I have been missing out on email notifications for some time.

Will review soon.

angularsen avatar Oct 31 '22 21:10 angularsen

The build reached maximum of 60 Minutes. Can someone restart it?

EDIT: Build seems to be normally at 58 Minutes. This is quite long. How does it come?

I have no idea, sometimes the vstest process seems to hang on AppVeyor. Other times, it is just slow. It is nowhere near as slow locally, I guess the free open source VMs have very limited capacity. In the old days it took 4-5 minutes on AppVeyor, so something has definitely changed over time.

angularsen avatar Nov 01 '22 22:11 angularsen

I tried upgrading a very outdated JetBrains' dotcover tool to hopefully fix the hang/slow builds. It seems to help locally at least. 🤞 #1146

angularsen avatar Nov 01 '22 23:11 angularsen