angular_components icon indicating copy to clipboard operation
angular_components copied to clipboard

MenuItem gallery example needs to be updated from deprecated action to actionWithConext

Open supermuka opened this issue 6 years ago • 1 comments

The analyzer shows the following message to MenuItem component:

'action' is deprecated and shouldn't be used.

However, the example in AngularDart Gallery is implemeting the deprecated action:

Material Menu/MaterialMenuDemoComponent /Source Code

Into MenuItem source code we have:

  MenuItem(this.label,
      { "...", 
      @Deprecated('Use ActionWithContext') MenuAction action,
      ActionWithContext actionWithContext,
       "..." })

It seems that the example needs to be updated.

Environment: Dart VM version: 2.6.0-dev.1.0 angular_components: version: "0.14.0-alpha+1"

supermuka avatar Sep 17 '19 23:09 supermuka

Good catch, thanks for pointing it out.

nshahan avatar Sep 18 '19 17:09 nshahan