dgeni icon indicating copy to clipboard operation
dgeni copied to clipboard

version all asset urls

Open IgorMinar opened this issue 11 years ago • 5 comments

we should add version number/build number/sha to urls for all assets so that when we deploy a new build to production we don't have issues with stale browser caches.

IgorMinar avatar Feb 17 '14 06:02 IgorMinar

What should we version them with? If we use the sha of the current build, then we will be invalidating all the assets every week, which seems a bit too severe.

I'll update the assets retrieved from bower to use their bower version. Perhaps we could do something clever and look at the last commit that affected each asset file and use that sha?

petebacondarwin avatar Feb 17 '14 08:02 petebacondarwin

I have partially sorted this: https://github.com/angular/angular.js/commit/4c02d0bea5ff7ce295d2a2f7ed005eac2c82706c

petebacondarwin avatar Feb 17 '14 17:02 petebacondarwin

@IgorMinar - any thoughts on what we should version the local assets with?

petebacondarwin avatar Apr 13 '14 20:04 petebacondarwin

We deploy docs on each commit so we would invalidate cache several time a day if we were to use the sha of the build. How about the sha of the individual asset? We could maybe even think of experimenting with identity urls which just landed in Chrome. On Sep 30, 2014 2:14 AM, "Pete Bacon Darwin" [email protected] wrote:

Closed #58 https://github.com/angular/dgeni/issues/58.

— Reply to this email directly or view it on GitHub https://github.com/angular/dgeni/issues/58#event-171965613.

IgorMinar avatar Sep 30 '14 16:09 IgorMinar

Ok I'll reopen and have a think about this further

petebacondarwin avatar Sep 30 '14 16:09 petebacondarwin