components icon indicating copy to clipboard operation
components copied to clipboard

fix(overlay): backdrop blocking element scroll

Open crisbeto opened this issue 6 years ago • 16 comments

Fixes a long-standing where the backdrop doesn't allow the user to scroll, if the main scrollable container is not the body.

Fixes #6927.

crisbeto avatar Oct 13 '17 19:10 crisbeto

I agree we should do this long term, but I a bit hesitant to do it before stable because I suspect many Google apps have come to expect the current behavior and would need to switch to BlockScrollStrategy. It will take us some time to communicate the change and have make sure people are getting the behavior they want. I'm thinking this should go on the list for susequent major release.

jelbourn avatar Oct 27 '17 21:10 jelbourn

@jelbourn just remembered about this one. Should we schedule it for 6.0?

crisbeto avatar Mar 05 '18 03:03 crisbeto

I don't think we have time before 6.0 to track down the stuff I mentioned above

jelbourn avatar Mar 05 '18 23:03 jelbourn

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. Please help to unblock it by resolving these conflicts. Thanks!

ngbot[bot] avatar Jul 11 '18 15:07 ngbot[bot]

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. Please help to unblock it by resolving these conflicts. Thanks!

ngbot[bot] avatar Jul 11 '18 15:07 ngbot[bot]

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. Please help to unblock it by resolving these conflicts. Thanks!

ngbot[bot] avatar Aug 03 '18 14:08 ngbot[bot]

@jelbourn do we still want to do this?

crisbeto avatar Aug 20 '18 10:08 crisbeto

I'd say this is lower priority than the other stuff we're doing for v7. If we're able to wrap up the visual changes and other stuff, we can see about getting this in.

jelbourn avatar Aug 20 '18 16:08 jelbourn

Any work around for this please ?

nadhir-falta avatar Oct 26 '18 06:10 nadhir-falta

any idea in which release can this PR make its way ?

hilnius avatar Jan 29 '19 21:01 hilnius

Any idea when this will make it in? I really want to use the components from Angular material, but this is kind of a blocker...

kokojvanko avatar Jul 31 '19 14:07 kokojvanko

Is there any update about this PR ?

Angular CDK is not only the base of Angular Material but also many other Angular UI libraries. The current behavior makes Angular Material websites different from other Material Design products like Google Keep.

rppig42 avatar Feb 14 '20 17:02 rppig42

@jelbourn, this is a long standing issue which prevents us & many to use this functionality. If you have no intension to implement it, please also let us know so we take it under consideration when using related material components.

gokhanoner avatar Apr 07 '20 21:04 gokhanoner

The problem with this change is that it's very difficult/breaking to land in Google, and there's a number of higher priority items that keep this (and many fixes of a similar nature) from being worked on.

jelbourn avatar Apr 23 '20 21:04 jelbourn

I see. Thanks @jelbourn . I believe I can think of this as a wont-fixed issue then.

gokhanoner avatar Apr 23 '20 21:04 gokhanoner

What is the prospect of making all those private functions protected, so we can at least extend the classes, apply this fix and provide them instead of the default ones? That way we can override the behavior, without changing the default one.

CnxYankoNikolov avatar Apr 24 '20 12:04 CnxYankoNikolov