components
components copied to clipboard
feat(cdk/overlay): Allow passing separate X and Y values for the view…
…portMargin
The overlay directive now accepts two additional (optional parameters) [viewportMarginX] and [viewportMarginY]. You can use these to pass separate margin values for the viewport.
Can you add a couple of tests to
src/cdk/overlay/position/flexible-connected-position-strategy.spec.ts?
Hi, done :)
Hi @crisbeto, could I get another review? Thanks!
Hi @crisbeto, I updated my tests and everything should build correctly now. Could you review again when you have time?
@crisbeto Right, sorry. I've moved it to another file now
Is there something else I need to change for this PR? I see the merge status and internal tests are failing but I'm unable to see any details
Thanks for the approval!
This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.