components icon indicating copy to clipboard operation
components copied to clipboard

feat(cdk/overlay): Allow passing separate X and Y values for the view…

Open LukeyBeachBoy opened this issue 1 year ago • 5 comments
trafficstars

…portMargin

The overlay directive now accepts two additional (optional parameters) [viewportMarginX] and [viewportMarginY]. You can use these to pass separate margin values for the viewport.

LukeyBeachBoy avatar Aug 09 '24 12:08 LukeyBeachBoy

Can you add a couple of tests to src/cdk/overlay/position/flexible-connected-position-strategy.spec.ts?

Hi, done :)

LukeyBeachBoy avatar Aug 18 '24 12:08 LukeyBeachBoy

Hi @crisbeto, could I get another review? Thanks!

LukeyBeachBoy avatar Oct 07 '24 09:10 LukeyBeachBoy

Hi @crisbeto, I updated my tests and everything should build correctly now. Could you review again when you have time?

LukeyBeachBoy avatar Oct 09 '24 07:10 LukeyBeachBoy

@crisbeto Right, sorry. I've moved it to another file now

LukeyBeachBoy avatar Oct 09 '24 09:10 LukeyBeachBoy

Is there something else I need to change for this PR? I see the merge status and internal tests are failing but I'm unable to see any details

LukeyBeachBoy avatar Oct 09 '24 18:10 LukeyBeachBoy

Thanks for the approval!

LukeyBeachBoy avatar Oct 02 '25 17:10 LukeyBeachBoy

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.