components icon indicating copy to clipboard operation
components copied to clipboard

fix(material/dialog): dialog name on mac only using aria-label

Open essjay05 opened this issue 1 year ago • 1 comments
trafficstars

Fixes bug with Angular Components Dialog component on Mac whether using Chrome or Firefox the screenreader does not read the dialog name/title unless it is using an aria-label. Updates the dialog-content-directives to read/apply the aria- labelledby and aria-describedby values if they exist.

Fixes b/274674581

essjay05 avatar Jun 14 '24 22:06 essjay05

Deployed dev-app for 119d68b114abbf1698a5901468c27e31caef9831 to: https://ng-dev-previews-comp--pr-angular-components-29264-dev-rjpcttjr.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

github-actions[bot] avatar Jun 14 '24 22:06 github-actions[bot]

Reverting this PR and closing as it looks like the aria-labelledby bug is specific to MacOS+Firefox even on a plain HTML/CSS/Vanilla Javascript Dialog and is not due to Angular Components.

essjay05 avatar Oct 04 '24 18:10 essjay05

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.