components icon indicating copy to clipboard operation
components copied to clipboard

docs(material/slider): value should go in the input tag

Open mruanova opened this issue 1 year ago • 3 comments

this screen is correct Screen Shot 2023-12-09 at 8 12 10 PM but this screen is wrong because the value should go in the input tag Screen Shot 2023-12-09 at 8 13 10 PM

mruanova avatar Dec 10 '23 02:12 mruanova

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Dec 10 '23 02:12 google-cla[bot]

corrected title of the pull request to satisfy lint

mruanova avatar Dec 12 '23 13:12 mruanova

The lint failure can be fixed when merging the change, but it looks like the CLA isn't signed. See https://github.com/angular/components/blob/main/CONTRIBUTING.md#cla

crisbeto avatar Dec 14 '23 10:12 crisbeto

@mruanova This is ready to merge in if you can sign the CLA - thanks!

mmalerba avatar Jan 10 '24 00:01 mmalerba

@mruanova This is ready to merge in if you can sign the CLA - thanks!

CLA signed

mruanova avatar Apr 10 '24 11:04 mruanova

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.