components
components copied to clipboard
bug(mat-dialog): mat-dialog-title adds a space in front of the header text when HTML is formatted
Is this a regression?
- [X] Yes, this behavior used to work in the previous version
The previous version in which this bug was not present was
14
Description
When using a header tag as a mat-dialog-title, there is a space at the beginning of the title, resulting in the dialog title not being aligned with the content:
![image](https://user-images.githubusercontent.com/8104336/216009793-59b0f171-da72-4d25-bc17-1a7ec02089b5.png)
This only happens if the content of the header tag in the HTML file is placed on a new line.
When using a header tag that contains a long expression, the default formatting (by Prettier, for example) puts the content of the header tag on the next line (as header tags are block elements), like so:
<h2 mat-dialog-title>
{{ getTitleThisFunctionHasAVeryLongNameSoPrettierPutsItOnANewLine() }}
</h2>
This results in a space being inserted in the HTML. However, since the browser ignores whitespace at the beginning of the element, the space is not visible (cf. HTML spec).
Sinde Material 15 however, elements containing mat-dialog-title
have a ::before
element. This element causes the browser to render the whitespace, which is inconsistent with default browser behavior and default formatting for block elements.
Reproduction
Steps to reproduce:
- Create a mat-dialog
- Add a header tag with mat-dialog-title
- As a header text, insert an expression that is quite long, causing Prettier to put it on the next line
The problem is illustrated in this Stackblitz.
Removing the ::before
element of the mat-dialog-title
, removes the whitespace, but causes the header height to be too small.
Expected Behavior
No whitespace should be visible, according to default behavior of both the browser and block element formatting.
Actual Behavior
Whitespace is visible at the beginning of the title.
Environment
- Angular: 15.1
- CDK/Material: 15.1.2
- Browser(s): Chrome
- Operating System (e.g. Windows, macOS, Ubuntu): macOS Ventura