components
components copied to clipboard
fix(material/list): add radio toggles
fix(material/list): add radio toggles
Add radio toggles for single selection. Fix a11y issue where selected state is visually communicated with color alone.
Rename checkboxPosition
Input to togglePosition
and deprecate
checkboxPosition
. togglePosition
configures the position of both the
radio and checkbox indicators. checkboxPosition
also configures the
position of both.
Summary of API and behavior changes:
- MDC List displays radio indicators for single-selection
- rename
checkboxPosition
Input totogglePosition
- rename
type MatListOptionCheckboxPosition
totype MatListOptionTogglePosition
DEPRECTED:
-
checkboxPosition
is deprecated becausetogglePosition
replaces it -
MatListOptionCheckboxPosition
is deprecated becauseMatListOptionTogglePosition
replaces it
Closes https://github.com/angular/components/issues/7157, Fixes https://github.com/angular/components/issues/25900
Hi all, I've made fixes to respond to PR comments
- update the code comments: say checkbox/radio or toggle instead of just checkbox
- delete
MatListOptionCheckboxPosition
and@Input checkboxPosition
, which are replaced byMatListOptionTogglePosition
and@Input togglePosition
- add
getRadioPosition
method to test harness
@crisbeto does this PR look good to you?
I've made fixed based on PR comments and changed the target to minor:
-
checkboxPosition
is deprecated becausetogglePosition
replaces it -
MatListOptionCheckboxPosition
is deprecated becauseMatListOptionTogglePosition
replaces it - export
MatListOptionCheckboxPosition
using theexport as
syntax 👌
@crisbeto @mmalerba this is ready for your eyes again :eyes:
changes since this was last reviewed:
- fixed regression in radio dark mode because MDC's global variables were not configured correctly
- consolidated calls to
using-mdc-theme
This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.