components icon indicating copy to clipboard operation
components copied to clipboard

feat(material/chips): allow custom default color

Open Nxtivision opened this issue 3 years ago • 6 comments
trafficstars

Lets the user choose what color will be the default instead of 'primary' via mixinColor

✅ Tests adapted ✅ No breaking change: I keep the same default color primary

Nxtivision avatar Sep 23 '22 12:09 Nxtivision

Thank you! 😄

Nxtivision avatar Sep 26 '22 14:09 Nxtivision

Thank you for the contribution :) I'll run this by internal Google tests to make sure it can be merged

andrewseguin avatar Sep 26 '22 14:09 andrewseguin

One more thing - youll need to run yarn bazel run //tools/public_api_guard:material/chips.md_api.accept to edit the API goldens

andrewseguin avatar Sep 26 '22 15:09 andrewseguin

There were some failures internally, I'll try to take a look this week to determine what's going on

andrewseguin avatar Sep 26 '22 17:09 andrewseguin

Hey thanks for your patience with this PR - this was on the backburner as we prepare v15's MDC launch. I looked at the failures. We need just one small change to chip-row.ts which calls the super MatChip constructor. You'll want to inject and pass the default options in the constructor.

andrewseguin avatar Oct 13 '22 17:10 andrewseguin

Good news is that now all tests pass internally and externally, but unfortunately this missed our window for getting in for v15. We're in a feature freeze until November's release, but once that passes we can get this merged in. Thanks for your contribution and patience :)

andrewseguin avatar Oct 15 '22 12:10 andrewseguin

Hi Andrew, Thank you for letting me know about this ! :) Can we expect it to be released before the end of this year ?

Nxtivision avatar Oct 18 '22 12:10 Nxtivision