components
components copied to clipboard
feat(material/chips): allow custom default color
Lets the user choose what color will be the default instead of 'primary' via mixinColor
✅ Tests adapted
✅ No breaking change: I keep the same default color primary
Thank you! 😄
Thank you for the contribution :) I'll run this by internal Google tests to make sure it can be merged
One more thing - youll need to run yarn bazel run //tools/public_api_guard:material/chips.md_api.accept to edit the API goldens
There were some failures internally, I'll try to take a look this week to determine what's going on
Hey thanks for your patience with this PR - this was on the backburner as we prepare v15's MDC launch. I looked at the failures. We need just one small change to chip-row.ts which calls the super MatChip constructor. You'll want to inject and pass the default options in the constructor.
Good news is that now all tests pass internally and externally, but unfortunately this missed our window for getting in for v15. We're in a feature freeze until November's release, but once that passes we can get this merged in. Thanks for your contribution and patience :)
Hi Andrew, Thank you for letting me know about this ! :) Can we expect it to be released before the end of this year ?