fix(material/tooltip): avoid problem when triggers hide animation for not visible tooltip

[volvachev]

trafficstars

This PR fixes the problem when mat-tooltip-hide triggers the animation of tooltip that has not been shown yet.

Fixes #24614

Caretaker note: Integration test is failing because selenium wants to click on a select item but instead is clicking on the tooltip

[google-cla[bot]]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

[volvachev]

A couple of notes:

1. I think that the correct approach would be to clear the tooltip opening timeout if the pointer is moved away.
2. I noticed this when I was reworking the tooltip in a5ab8e9, but I ended up keeping the old behavior, because it caused a lot of screenshot failures internally.

The problem is that during the hide action mat-tooltip-hide class is added which has @keyframes -> opacity: 1; animation. As a result hint is shown and disappears in the end of animation, but it hasn't be shown at all. In case when tooltip shouldn't be shown we need to avoid such animation.

After mouseleave event open timeout wipes.

[rajibhasan11]

Any update on this?

[zarend]

Hello @volvachev, we're running this PR through Google's internal presubmit. Could you please rebase this branch with master?

[volvachev]

Hello @volvachev, we're running this PR through Google's internal presubmit. Could you please rebase this branch with master?

Hi, I did it.

[zarend]

tyty, the most recent presubmit process from earlier this week had less than ten failures. I'm kicking off a fresh one.

[volvachev]

tyty, the most recent presubmit process from earlier this week had less than ten failures. I'm kicking off a fresh one.

So, will my fix be included in new one?

[Juszczak]

Any updates?

[wagnermaciel]

@volvachev The presubmit process Zach was describing was for this PR. Each PR is processed independently

From the latest presubmit run, I can see that it only had a handful of failures so it (hopefully) shouldn't be too difficult to get through. Unfortunately I haven't been able to prioritize this enough to sit down and debug each failure

[NoMercy235]

Hello! It looks like there are no failed checks anymore. Is there any update on this PR?

[cosme-benito]

Any news about this PR? The impacts of this bug are quite unpleasant for the users.

[vasyop]

are we there yet?

[NoMercy235]

Pretty please? 🙏

[wagnermaciel]

I'll take another look. We got this down pretty close but the internal failures are tough to debug. After rerunning internal tests tonight I'll post an update on how things are looking

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}