components icon indicating copy to clipboard operation
components copied to clipboard

feat(cdk/tree): implement the various skeleton methods

Open BobobUnicorn opened this issue 3 years ago • 8 comments

BobobUnicorn avatar Feb 25 '22 22:02 BobobUnicorn

@BobobUnicorn Are these draft PRs still being worked on? Feel free to sync with me via Chat if you want guidance going forward on this tree redesign

andrewseguin avatar May 12 '22 11:05 andrewseguin

Yeah, I'd been out for a little while; I'll get these cleaned up for review.

BobobUnicorn avatar May 16 '22 18:05 BobobUnicorn

CI seems to be failing - want to try rebasing and trying it again?

andrewseguin avatar Aug 01 '22 13:08 andrewseguin

@andrewseguin I think the cdk-tree-revamp branch in this repo would also need to be rebased.

BobobUnicorn avatar Aug 09 '22 04:08 BobobUnicorn

@BobobUnicorn Did you need help rebasing the branch? Looks like this PR is in a distorted place with 2,000 files and 500 commits

andrewseguin avatar Aug 26 '22 11:08 andrewseguin

@andrewseguin I do not have permissions to update the branch in this repository

BobobUnicorn avatar Aug 30 '22 19:08 BobobUnicorn

Ah gotcha, would you like to open a PR from your local rebased branch that just updates this branch

andrewseguin avatar Sep 01 '22 12:09 andrewseguin

#25613 should do it

BobobUnicorn avatar Sep 09 '22 17:09 BobobUnicorn

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.