components icon indicating copy to clipboard operation
components copied to clipboard

fix: input coercion

Open lekhmanrus opened this issue 4 years ago • 4 comments

Applied missed boolean/number coercion for @Input's.

lekhmanrus avatar Jul 12 '21 08:07 lekhmanrus

@crisbeto is there anything I can do?

lekhmanrus avatar Sep 20 '21 22:09 lekhmanrus

As I mentioned above, we'd have to measure how much of an effect this has on bundle sizes. I also expect this to conflict with https://github.com/angular/components/pull/23606.

crisbeto avatar Sep 21 '21 05:09 crisbeto

I'm not sure what command should I run to measure it. I used approve-size-tests. size-test.yaml:

cdk/drag-drop/all-directives: 155979
cdk/drag-drop/basic: 153337
-material-experimental/mdc-chips/basic: 188774
+material-experimental/mdc-chips/basic: 189051
-material-experimental/mdc-form-field/advanced: 222655
+material-experimental/mdc-form-field/advanced: 222932
-material-experimental/mdc-form-field/basic: 221144
+material-experimental/mdc-form-field/basic: 221421
-material/autocomplete/without-optgroup: 208957
+material/autocomplete/without-optgroup: 209400
-material/button-toggle/standalone: 120880
+material/button-toggle/standalone: 121327
-material/chips/basic: 163503
+material/chips/basic: 163506
-material/datepicker/range-picker/without-form-field: 327676
+material/datepicker/range-picker/without-form-field: 328217
material/expansion/without-accordion: 134600
material/form-field/advanced: 181564
material/form-field/basic: 179979
-material/list/nav-list: 128581
+material/list/nav-list: 128949
-material/menu/without-lazy-content: 214482
+material/menu/without-lazy-content: 214941
-material/radio/without-group: 124015
+material/radio/without-group: 124287
-material/select/basic: 256683
+material/select/basic: 257287
-material/tabs/advanced: 183425
+material/tabs/advanced: 183988
-material/tabs/basic: 182564
+material/tabs/basic: 183127

lekhmanrus avatar Sep 21 '21 18:09 lekhmanrus

@crisbeto Despite adding to the code size, it does seem like we should have had these from the beginning. Should we request the author to rebase?

andrewseguin avatar Mar 24 '22 19:03 andrewseguin

Closing since this PR hasn't been touched in a long time and it has a lot of conflicts.

crisbeto avatar Dec 11 '23 11:12 crisbeto

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.