feat(select): configurable panel max-height

[RudolfFrederiksen]

Add an option to mat-select to configure panel max-height

Fixes #15803

and probably #11780, #15192 too

[yakimko]

any updates on this?

[RudolfFrederiksen]

@crisbeto thanks for the review I'll try to get some time to work on this. Probably by the end of this week.

[googlebot]

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[RudolfFrederiksen]

I apologize to people who got requested for review. I messed up my rebase and forced pushed before seeing commit hash had changed. It's fixed now.

@crisbeto I've read your comments and made some modifications. I also added some basic unit test and a bit of documentation. Tell me if that looks good to you.

[keatkeat87]

any update ?

[vitalikdum]

Hi @RudolfFrederiksen , I've faced the same issue in my project. Is there any update about this PR?

[JoaoSaleiro]

Being able to set the max-height is something we really need. We've forced it via CSS, but that solution creates an UX bug when the is multiple: if the user selects one of the last options, the scrollbar "jumps" and the user gets confused of what happened. Here's a GIF with the problem: https://gyazo.com/9af65ceb203ad1ee155cf6988fdba899

So, the mat-select by default shows too litle options, but we're stuck with it.

Is there another solution for this issue?

[ThomazAquino]

any update ?

[elenachiosa]

Any updates? Can someone please fix the conflicts and merge? We also need this on the project. Hard coded values cause issues when we try to add a "Select all" functionalty to mat select and keyboard accessiblity also breaks.

[crisbeto]

@elenachiosa this is unlikely to land, however you can try the new mat-select implementation from @angular/material-experimental/mdc-select. It has the exact same functionality, with the major difference being that we don't have to do fancy positioning with the dropdown panel so the height doesn't have to be hardcoded.

All you have to do to migrate is change the @angular/materia/select imports to @angular/material-experimental/mdc-select.

[crisbeto]

This change isn't necessary anymore since we no longer have a hardcoded panel height.

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}