components icon indicating copy to clipboard operation
components copied to clipboard

fix(material/radio): clear names from host nodes

Open crisbeto opened this issue 6 years ago • 4 comments
trafficstars

Along the same lines as #15368. Clears the name from the host node of the radio button and radio group, because they end up being forwarded to the underlying input and can cause double results when using something like getElementsByName.

crisbeto avatar Mar 08 '19 23:03 crisbeto

Shoud the name be assigned to the inner input? In a test within google3, the input within the radio had this name "mat-radio-group-0" instead of what was being passed in.

amysorto avatar May 11 '22 19:05 amysorto

@crisbeto Heads up that Amy has a quick question about going forward on this change

andrewseguin avatar Aug 15 '22 15:08 andrewseguin

I think that we talked through this over DM at some point. The fix is correct, but it ended up breaking internally because apps were projecting all sorts of unrelated content into the radio buttons.

crisbeto avatar Aug 15 '22 15:08 crisbeto

Gotcha thanks - @amysorto Do you have a good idea on how to get those tests passing with this change? Feel free to pair with myself or Kristiyan to get this in

andrewseguin avatar Aug 15 '22 15:08 andrewseguin

Looks like this is really breaking internally. I'll close it for now since we haven't gotten any issue reports about it.

crisbeto avatar Feb 28 '24 08:02 crisbeto

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.