components icon indicating copy to clipboard operation
components copied to clipboard

fix(dialog,bottom-sheet): invert backdrop color on dark themes

Open crisbeto opened this issue 5 years ago • 2 comments

Similarly to how we handle the sidenav backdrop and ripples, these changes invert the color for the dialog and bottom sheet backdrops in dark themes.

Note: this is a resubmit of #13065.

crisbeto avatar Dec 13 '18 17:12 crisbeto

I see that you just added the pr: merge ready label, but the following checks are still failing:     failure status "ci/circleci: tests_saucelabs" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

ngbot[bot] avatar Dec 13 '18 18:12 ngbot[bot]

@crisbeto it looks like this is changing the backdrop color for light themes as well, which is causing a lot of screenshot diffs

jelbourn avatar Dec 19 '18 21:12 jelbourn

AFAIK this isn't in the spec. Closing.

crisbeto avatar Feb 28 '24 08:02 crisbeto

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.