components
components copied to clipboard
fix(chips): multi-line chips not looking correctly
A while ago we added a height: 1px
to the chips, in order to work around a flexbox issue in IE. This ended up breaking the chip if it has multiple lines of text. These changes remove the height
hack and rework the margins on the avatar to fix the original issue on all browsers.
Fixes #13946.
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. Please help to unblock it by resolving these conflicts. Thanks!
Is this ready to merge? This solves the problem I have.
any plans on merging this soon?
This PR was blocked because it caused chips to become slightly larger in a number of projects inside Google, which would impact the layouts in those apps. Unfortunately no ETA currently on when we'll be able to revisit and see if we can make it less breaking.
Closing since this fix is for the legacy mat-chips which has been superseded by the MDC based one.
This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.