components icon indicating copy to clipboard operation
components copied to clipboard

Add `completed` event for stepper / steps

Open olman21 opened this issue 6 years ago • 14 comments

Bug, feature request, or proposal:

Proposal

What is the expected behavior?

Optionally allow the consumer define if it wants to auto-advance an step when it completes (by using [completed] step property)

What is the current behavior?

Nothing happens as soon the step is marked as completed

What is the use-case or motivation for changing an existing behavior?

Use Observable based state such as NgRx stores, and in a more functional way allow set the stepper navigation based on state, now I have to subscribe to store and call navigation via an stepper instance in order to handle steps advance, too imperatively and also results in a awful timing issues because when stepper.next() is called and [completed] property update is on its way nothing happens.

Is there anything else we should know?

I'm willing to implement such feature. No breaking changes would be introduced.

olman21 avatar Aug 30 '18 17:08 olman21

It seems reasonable and if it can be done in a non-breaking way I am sure we would welcome the contribution.

@mmalerba to confirm.

josephperrott avatar Sep 07 '18 15:09 josephperrott

I assume you mean an output (completed) rather than an input [completed] correct? That seems like a reasonable feature to me

mmalerba avatar May 27 '20 18:05 mmalerba

Updated this to clarify the feature we would add here: introducing a completed event for the stepper/steps so that the application could do whatever it wants upon completion.

jelbourn avatar Aug 12 '21 17:08 jelbourn

Hej there! This would be my first issue but I would love to tackle it.

pkirchniawy avatar Dec 11 '21 19:12 pkirchniawy

Sure, you can add me as a reviewer on your PR when you're ready

mmalerba avatar Jan 04 '22 23:01 mmalerba

@mmalerba If this issue is still open, I can take it up ?

ramprakashram avatar Jan 21 '22 11:01 ramprakashram

Hej @ramprakashram I'm currently working on it :)

pkirchniawy avatar Jan 21 '22 14:01 pkirchniawy

Sure then @pkirchniawy

ramprakashram avatar Jan 21 '22 14:01 ramprakashram

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

angular-robot[bot] avatar Feb 01 '22 18:02 angular-robot[bot]

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.

angular-robot[bot] avatar Feb 22 '22 15:02 angular-robot[bot]

I assume you mean an output (completed) rather than an input [completed] correct? That seems like a reasonable feature to me

I think, the initial request was to use the already existing input [completed] value to ask to move to the next step if a new optional input [auto-advance] is enabled.

So, if [completed] is set to true, then the stepper will automatically move to the next step.

synopss avatar Jun 25 '22 16:06 synopss

I agree with @synopss, but also believe that the two use cases (exposing an event (completed) and creating an input [auto-avance]) could be very beneficial and shouldn't break existing functionality.

jomendez avatar Jan 07 '23 06:01 jomendez

~~I've created an PR for this request: #26817.~~

I've created an PR for this request: #26819. ( I messed up Google's CLA, was logged into wrong account. apologies! )

This is my first time contributing, please shed light if I have something wrong or missed out something.

naaajii avatar Mar 22 '23 11:03 naaajii

Is someone working on it? @naaajii you deleted your branch?

Can someone just clarify what is still needed as there is a few use cases proposed and the stepper has been Amended since issue was raised 6 years ago?

skilledDev96 avatar Apr 14 '24 14:04 skilledDev96