clutz icon indicating copy to clipboard operation
clutz copied to clipboard

Fix enum bug in module legacy namespace.

Open nbeloglazov opened this issue 5 years ago • 4 comments

nbeloglazov avatar Sep 27 '19 18:09 nbeloglazov

Actually hold on. I think the bug is not fixed. Clutz produces different output depending on goog.module name I just got lucky in the test.

nbeloglazov avatar Sep 28 '19 00:09 nbeloglazov

Ready for review.

nbeloglazov avatar Oct 04 '19 18:10 nbeloglazov

Can you rebase, this looks good.

rkirov avatar Oct 24 '19 23:10 rkirov

This change doesn't work in one case like:

goog.module('foo');

const bar = goog.require('bar');

/** @enum {number} */
const Color = bar.Color;
exports.Color = Color;

where bar is coming from another module (so its source is not processed by Clutz). Need to figure out how it should be handled.

nbeloglazov avatar Oct 25 '19 14:10 nbeloglazov