benchpress icon indicating copy to clipboard operation
benchpress copied to clipboard

lib/template.html - <title>

Open danmindru opened this issue 11 years ago • 1 comments

Hey,

The template <title> was confusing to me -> https://github.com/angular/benchpress/blob/master/lib/template.html#L4

I saw that you want to remove the 'build' step, is that going to change how the template works altogether? It'll be handy to be able to set a title for each benchmark, especially when there are many tabs open.

Thanks for the great work. Dan

danmindru avatar Dec 05 '14 16:12 danmindru

Sorry, that was an artifact from when I was copying code from the angular/angular.dart repo.

With the separation of reporting and running applications (along with removal of the build step), the benchmark app can do whatever it wants with the document, and will be required to do a little bit more work as outlined in #18

jeffbcross avatar Dec 08 '14 17:12 jeffbcross