angularfire icon indicating copy to clipboard operation
angularfire copied to clipboard

Module is not defined error with Angular 16 esbuild

Open stolotti opened this issue 1 year ago • 10 comments

Version info

Angular: 16.0.3

Firebase: 9.0.0

AngularFire: 7.6.1

How to reproduce these conditions

Enable esbuild in angular.json

        "build": {
          "builder": "@angular-devkit/build-angular:browser-esbuild",
          "options": {

build: ng build && ng serve

Debug output

Uncaught ReferenceError: module is not defined
    <anonymous> Angular
angular-fire-compat.js:166:17

Expected behavior

I'm expecting the app to correctly work. I'm aware that The esbuild-based browser application builder ('browser-esbuild') is currently in developer preview.

Actual behavior

White page and console error.

stolotti avatar Jun 01 '23 06:06 stolotti

Hi @stolotti @davideast, any updates? It would be great if you can fix this bug asap. Because just of this bug, we are not able to make use of ESbuild for our whole project.

Best regards, Thomas

ThomasLohmann avatar Jul 03 '23 14:07 ThomasLohmann

Same here...we're stuck because of this bug

andreagrossetti avatar Jul 07 '23 07:07 andreagrossetti

any updates ?

Best regards, Arthur

arthur-noiret avatar Jul 26 '23 09:07 arthur-noiret

We are also waiting on a resolution here.

lukerfx avatar Jul 27 '23 20:07 lukerfx

any updates?

jmeinlschmidt avatar Aug 25 '23 14:08 jmeinlschmidt

+1

gianmd avatar Oct 06 '23 15:10 gianmd

This is really a big issue, guys

spock123 avatar Nov 15 '23 12:11 spock123

Angular: 16.0.3 Firebase: 9.0.0 AngularFire: 7.6.1

Anyone here already tried to bump angularfire in your project to 16.0.0?

Looks like there are some (other) bumps shipped with this 16.0.0 version (although it's not really described in the changelog) https://github.com/angular/angularfire/blob/7.6.1/package.json ("firebase": "^9.8.2") https://github.com/angular/angularfire/blob/16.0.0/package.json ("firebase": "^10.0.0")

basvandorst avatar Nov 27 '23 14:11 basvandorst

I have and so far no issues

On Mon, 27 Nov 2023, 15.03 Bas, @.***> wrote:

Angular: 16.0.3 Firebase: 9.0.0 AngularFire: 7.6.1

Anyone here already tried to bump angularfire in your project to 16.0.0?

Looks like there are some (other) bumps shipped with this 16.0.0 version (although it's not described in the changelog https://github.com/angular/angularfire/releases https://github.com/angular/angularfire/blob/7.6.1/package.json ("firebase": "^9.8.2") https://github.com/angular/angularfire/blob/16.0.0/package.json ("firebase": "^10.0.0")

— Reply to this email directly, view it on GitHub https://github.com/angular/angularfire/issues/3367#issuecomment-1827894458, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJVM5AEYHQCBFBNKJEL2ALYGSMUNAVCNFSM6AAAAAAYWOJVWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRXHA4TINBVHA . You are receiving this because you commented.Message ID: @.***>

spock123 avatar Nov 27 '23 15:11 spock123

any solution?

"firebase": "^9.6.9",
"@angular/fire": "^7.2.1",
"executor": "@angular-devkit/build-angular:browser-esbuild",
Node   : 18.13.0
OS     : darwin-arm64
npm    : 8.19.3

nx                 : 18.2.4
@nx/js             : 18.2.4
@nx/jest           : 18.2.4
@nx/linter         : 18.2.4
@nx/eslint         : 18.2.4
@nx/workspace      : 18.2.4
@nx/angular        : 18.2.4
@nx/cypress        : 18.2.4
@nx/devkit         : 18.2.4
@nx/eslint-plugin  : 18.2.4
@nx/express        : 18.2.4
@nx/node           : 18.2.4
@nx/storybook      : 18.2.4
@nrwl/tao          : 18.2.4
@nx/web            : 18.2.4
@nx/webpack        : 18.2.4
nx-cloud           : 18.0.0
typescript         : 5.4.5
---------------------------------------
Community plugins:
@fortawesome/angular-fontawesome : 0.9.0
@ngneat/tailwind                 : 7.0.3
@scullyio/init                   : 2.1.41
@storybook/angular               : 7.6.17
rxjs                             : 6.6.7

ohabash avatar Apr 11 '24 18:04 ohabash