angularfire icon indicating copy to clipboard operation
angularfire copied to clipboard

fix(schematics): rewrite `projectFromRc` and add spec file

Open nontangent opened this issue 2 years ago • 3 comments

Checklist

  • [x] Issue number for this PR: https://github.com/angular/angularfire/issues/3077 (required)
  • [x] Docs included?: no
  • [x] Test units included?: yes
  • [x] In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Fix https://github.com/angular/angularfire/issues/3077 and add unit tests.

Code sample

No API changes.

nontangent avatar Nov 04 '22 05:11 nontangent

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Nov 04 '22 05:11 google-cla[bot]

I've just signed CLA.

nontangent avatar Nov 04 '22 06:11 nontangent

I think this would fix https://github.com/angular/angularfire/issues/3309

arlopezg avatar Mar 19 '24 12:03 arlopezg