angularfire icon indicating copy to clipboard operation
angularfire copied to clipboard

fix(deploy): deploying with service account

Open zal1000 opened this issue 2 years ago • 1 comments

Deploying with service account was not possible, becouse no checks were made for GOOGLE_APPLICATION_CREDENTIALS env variable

Fixes #3260

Checklist

  • Issue number for this PR: #3260
  • Docs included?: no
  • Test units included?: no
  • In a clean directory, yarn install, yarn test run successfully? yes

Description

Not trying to log into firebase CLI when GOOGLE_APPLICATION_CREDENTIALS are detected. Doing that allows the deploy job to run in an automated env with a service account only

Code sample

zal1000 avatar Aug 20 '22 15:08 zal1000

Thanks for the fix, I'll look at merging this in for a patch release ASAP

jamesdaniels avatar Aug 24 '22 00:08 jamesdaniels

Hi, Do we have any update merging this MR? Firebase is deprecating the FIREBASE_TOKEN env variable for authentication. So need to authenticate using the service account. It would be good if the application picked up the GOOGLE_APPLICATION_CREDENTIALS env variable.

Kunal-Deshpande avatar Nov 22 '22 16:11 Kunal-Deshpande

Is there any update on this matter? thanks

HmFlashy avatar Apr 11 '23 15:04 HmFlashy

Please could someone take care of this PR? It would be really awesome thanks

HmFlashy avatar Apr 18 '23 14:04 HmFlashy

Closing but was merged in #3396

davideast avatar Jun 26 '23 19:06 davideast