angularfire
angularfire copied to clipboard
fix(deploy): deploying with service account
Deploying with service account was not possible, becouse no checks were made for GOOGLE_APPLICATION_CREDENTIALS env variable
Fixes #3260
Checklist
- Issue number for this PR: #3260
- Docs included?: no
- Test units included?: no
- In a clean directory,
yarn install
,yarn test
run successfully? yes
Description
Not trying to log into firebase CLI when GOOGLE_APPLICATION_CREDENTIALS
are detected.
Doing that allows the deploy job to run in an automated env with a service account only
Code sample
Thanks for the fix, I'll look at merging this in for a patch release ASAP
Hi, Do we have any update merging this MR? Firebase is deprecating the FIREBASE_TOKEN env variable for authentication. So need to authenticate using the service account. It would be good if the application picked up the GOOGLE_APPLICATION_CREDENTIALS env variable.
Is there any update on this matter? thanks
Please could someone take care of this PR? It would be really awesome thanks
Closing but was merged in #3396