angular icon indicating copy to clipboard operation
angular copied to clipboard

refactor(NgOptimizedImage): Update the InputChanged error

Open tidusjar opened this issue 1 year ago • 3 comments

Update it to mention using @if rather than the *ngIf directive

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] angular.dev application / infrastructure changes
  • [ ] Other... Please describe:

What is the current behavior?

Currently it references using the *ngIf directive

Issue Number: N/A

What is the new behavior?

It will suggest to use the @if control flow block

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

tidusjar avatar Nov 13 '24 16:11 tidusjar

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Nov 13 '24 16:11 google-cla[bot]

I think it makes sense for this to be a refactor commit instead of fix, as there isn't really a bug being fixed here.

JoostK avatar Nov 13 '24 19:11 JoostK

@tidusjar thanks for the update. I've noticed that you've updated the PR description, but the commit message remains the same. Could you please update the commit message as well (for example, using the git commit --amend command)? The commit message can be:

refactor(common): update the NgOptimizedImage message to use `@if` instead of `*ngIf`

This commit updates an error message to mention `@if` rather than the `*ngIf` directive.

AndrewKushnir avatar Nov 15 '24 00:11 AndrewKushnir

Can you make sur to drop that merge commit and squash the rest. We'd like this change to be a single commit. Thank you.

JeanMeche avatar Nov 22 '24 17:11 JeanMeche

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.