refactor(router): Update integration tests to cover navigation and history API

[atscott]

This commit updates the router integration tests to cover both the classic History and the new Navigation API. There is more work to be done here, but this commit works to prove the efficacy of the FakeNavigation implementation.

[ngbot[bot]]

I see that you just added the action: merge label, but the following checks are still failing:      conflicts with base branch "main"      status "google-internal-tests" is failing      status "pullapprove" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

[atscott]

This PR was merged into the repository by commit eb2e879a008adebe11d63f42799570ba4f053c52.

[atscott]

This seems blocked by the API extractor because of the private export referencing Navigation types.

// cc @devversion

[devversion]

@atscott is Navigation (the implements Navigation part) referring to a browser global of dom.d.ts? seems like this fails to resolve.

[atscott]

@atscott is Navigation (the implements Navigation part) referring to a browser global of dom.d.ts? seems like this fails to resolve.

It is a browser global provided by @types/dom-navigation. I think this came up before with @types/dom-view-transitions and we decided to just duplicate the one interface we needed to punt the problem down the road a bit. That's a bit more difficult here since there are a lot more types we'd need to duplicate. It's still possible but it would be good to fix this if we can.

[devversion]

I can look more, but maybe the type package is not mentioned in the API golden rule via the "types" attributr

[atscott]

@devversion That would be helpful. I wasn't able to figure it out.

[devversion]

@atscott I tried reproducing this locally, but not sure if you are seeing the same, but I don't even see these failures on my end?

 ~/projects/angular  @fd22a511 *73  git --no-pager log --max-count=3                                                                         INT х  pgschwendtner@devversion  12:20:31 PM 
commit fd22a51175307d3eadbf3fed3d09d329837d2c9a (HEAD)
Author: Andrew Scott <[email protected]>
Date:   Mon Jan 22 11:40:11 2024 -0800

[atscott]

@devversion it’s the npm_package target that’s failing to build on CI it seems. We fixed it locally with the ///references directive but it doesn’t seem to have fixed it on CI

[atscott]

caretaker note: Tom's approval should be sufficient here. build file updates are trivial and do not need dev-infra review

[jessicajaniuk]

This PR was merged into the repository by commit 15c48113c23d95a622bcb798f62e33e751509cb9.

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}