angular icon indicating copy to clipboard operation
angular copied to clipboard

docs: Add a doc for NG5014

Open JeanMeche opened this issue 1 year ago • 6 comments

Short explanation this help fix the Root node not found error.

I got the idea when I saw #50564.

JeanMeche avatar Jun 04 '23 15:06 JeanMeche

Caretaker note: low risk change, no extra reviews are required. We can also skip presubmit for this change. This PR is ready for merge (once CI is "green").

AndrewKushnir avatar Jun 07 '23 22:06 AndrewKushnir

@JeanMeche it looks like the test_aio failures are real as those don't go away after restart.

Could you PTAL?

pkozlowski-opensource avatar Jun 09 '23 09:06 pkozlowski-opensource

The aio tests are flaky, I'll try a rebase.

JeanMeche avatar Jun 12 '23 15:06 JeanMeche

Deployed aio for 3addb8ab38e9eaa0d2e5071fc9d659f9d456137a to: https://ng-dev-previews-fw--pr-angular-angular-50567-5fgmziv8.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

github-actions[bot] avatar Jun 13 '23 05:06 github-actions[bot]

@JeanMeche I've rebased this PR but still see the same aio tests jobs failing - so as unlikely as it sounds, it seems like there is something more than a flake going on. Going to remove the merge label for now, lmk if you need help debugging those tests.

pkozlowski-opensource avatar Jun 20 '23 14:06 pkozlowski-opensource

I not against some help yes.

I'm wondering if the issue is maybe related to #50537.

JeanMeche avatar Jun 20 '23 16:06 JeanMeche

This PR was merged into the repository by commit 0522f1b35355d4772f70fa941c7c566d84236316.

AndrewKushnir avatar Jun 27 '23 22:06 AndrewKushnir

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.