angular icon indicating copy to clipboard operation
angular copied to clipboard

fix(compiler-cli): accept inheriting the constructor from a class in …

Open JoostK opened this issue 3 years ago • 1 comments

…a library

The stricter checks under strictInjectionParameters in Angular 15 now enforce that an inherited constructor must be compatible with DI, based on whether all parameters are valid injection tokens. There is an issue when the constructor is inherited from a class in a declaration file though, as information on the usage of @Inject() is not present within a declaration file. This means that this stricter check cannot be accurately performed, resulting in false positives.

This commit disables the stricter check to behave the same as it did prior to Angular 15, therefore avoiding the false positive.

Fixes #48152

JoostK avatar Nov 21 '22 20:11 JoostK

Caretaker Note: Please ignore the google-internal-tests status. Unrelated flaky failures

ChanduMdp avatar Nov 22 '22 16:11 ChanduMdp

This PR was merged into the repository by commit 7d8870093313575d89c8abe584c43d6fa8105fc8.

dylhunn avatar Nov 23 '22 20:11 dylhunn

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.