angular.io icon indicating copy to clipboard operation
angular.io copied to clipboard

Published 20 hours ago • verified publisher icon angular

Angular-GraphQL cookbook

Open Urigo opened this issue 8 years ago • 13 comments

Hello!

This PR is for an Angular & GraphQL cookbook and includes everything an Angular developer needs in order to integrate GraphQL into their Angular apps.

It includes:

  • [x] Full cookbook of how to use GraphQL in your Angular app

  • [x] Full Clone of Tour Of Heroes last chapter with in-memory-graphql instead of on-memory REST

  • [x] All Tests pass both for JIT and AOT

  • [x] Working Plunker

  • [x] Green Lint

  • We've also updated a lot of libraries during that process to be compatible with Rollup and AOT

  • [x] apollo-client

  • [x] apollo-client-rxjs

  • [x] apollo-angular (and renaming from angular2-apollo #JustAngular)

  • [x] GraphQL-js

I believe I’ve followed all the guidelines needed but I’m also here in SF for 2 weeks if you need me to come over for a review!

Urigo avatar Jan 25 '17 02:01 Urigo

Soooooooooooooo awesome!

kamilkisiela avatar Jan 26 '17 11:01 kamilkisiela

Cool!! :)

DxCx avatar Jan 26 '17 11:01 DxCx

Good job!

alonp99 avatar Jan 29 '17 08:01 alonp99

Updated and rebased to latest master and included the changes made on these PRs:

  • https://github.com/angular/angular.io/pull/3171
  • https://github.com/angular/angular.io/pull/3176
  • https://github.com/angular/angular.io/pull/3157

All the tests of my PR passes but the tests for the server-communication example are failing.. @wardbell I've checked out master (without my changes) locally and the tests are failing as well. Also I've looked at the deployed version here - https://angular.io/docs/ts/latest/guide/server-communication.html Opened the live example in Plunker and it failed as well (changed the Wikipedia url inside the example to https to overcome another problem and then got the one the is happening also in the build). This is weird because I can see that CI was passing in the last commit to master. Just to be completely sure I also clone the angular.io master on another machine and had the same error. I can maybe try to solve it but I'm not sure I want to change your examples as part of this PR, maybe as part of another one. What would you suggest? Thanks

Urigo avatar Feb 03 '17 09:02 Urigo

ohhh just spotted this and that good to know I'm not crazy :)

Urigo avatar Feb 03 '17 10:02 Urigo

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot avatar Feb 07 '17 04:02 googlebot

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot avatar Feb 07 '17 04:02 googlebot

CLAs look good, thanks!

googlebot avatar Mar 18 '17 13:03 googlebot

CLAs look good, thanks!

googlebot avatar Mar 18 '17 13:03 googlebot

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot avatar Mar 20 '17 17:03 googlebot

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot avatar Mar 20 '17 17:03 googlebot

@googlebot I signed it

kamilkisiela avatar Mar 22 '17 08:03 kamilkisiela

FYI, I have to switch gears for a little bit, but will be back to work on this PR. Looking forward to seeing this cookbook in the docs!

kapunahelewong avatar Mar 27 '17 19:03 kapunahelewong