angular.io icon indicating copy to clipboard operation
angular.io copied to clipboard

SystemJS 0.20 upgrade path breaks quickstart plunkr

Open guybedford opened this issue 8 years ago • 9 comments

Just been testing out this upgrade path and this will affect Angular TypeScript workflows.

The underlying issue is https://github.com/frankwallis/plugin-typescript/issues/185, which is caused by the fact that SystemJS 0.20 no longer provides named exports for legacy modules.

Just let me know if I can assist further with any of this at all.

guybedford avatar Jan 24 '17 11:01 guybedford

Heya @guybedford, thanks for giving us a heads up! We're going to look into these changes and what we can do to mitigate them.

Again, thanks!

filipesilva avatar Jan 24 '17 13:01 filipesilva

From what I can tell from https://github.com/frankwallis/plugin-typescript/issues/185 and https://github.com/frankwallis/plugin-typescript/issues/185#issuecomment-274902258 specifically, it sounds like the upcoming update to plugin-typescript should make it pretty seamless for the quickstart and the rest of the examples.

I'll test the releases and update our examples accordingly.

filipesilva avatar Jan 25 '17 10:01 filipesilva

@filipesilva Hi, i am right now in the same boat and unable to make a Plunker + Typescript working.

If you ever find a solution for plnkr, could you please post the link here? Ill do the same.

Thanks!

Rouche avatar Jan 26 '17 14:01 Rouche

@Rouche see https://github.com/frankwallis/plugin-typescript/issues/185#issuecomment-275404583. I have a setup working at the moment but it's not final.

filipesilva avatar Jan 26 '17 14:01 filipesilva

@filipesilva Ok, I tryed a lot of stuff, following the Install step in the plugin but im stuck. Seems like angular.default.module is not present. http://plnkr.co/edit/BXxSxqJQP7CKBtDvUagY?p=preview

Rouche avatar Jan 26 '17 15:01 Rouche

@Rouche you seem to be using an AngularJS project, which changes things a bit... I only investigated how to update Angular (2) plunkers.

Can you give me a plunker that worked before System 0.20 ?

filipesilva avatar Jan 26 '17 15:01 filipesilva

Here : http://plnkr.co/edit/Fyo744DfAfRimIQ9hxBw?p=preview The new->Angular 1 + Typescript updated to latests version work fine.

The difference in 0.19 is we did not had to configure the transpiler plugin explicitelly.

Rouche avatar Jan 26 '17 15:01 Rouche

Ok I see now... the problem you're having is a bit different. AngularJS is not in UMD format so these solutions do not apply.

This works though:

meta: {
  'angular': { format: 'global' },
}

filipesilva avatar Jan 26 '17 16:01 filipesilva

@filipesilva That was too simple. Thanks, its working. Updated plunk. I guess i can send the template to Plnker so they update the default new...

Rouche avatar Jan 26 '17 16:01 Rouche