angular-electron icon indicating copy to clipboard operation
angular-electron copied to clipboard

Build fails with TypeScript 1.8. Pin the typescript version down to 1.7

Open vivainio opened this issue 8 years ago • 4 comments

TypeScript 1.8 fails with

node_modules/angular2/src/facade/promise.d.ts(1,10): error TS2661: Cannot re-export name that is not defined in the module.

Pinning TypeScript down to 1.7 is a quick fix to make the project build & run

vivainio avatar Mar 24 '16 20:03 vivainio

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot avatar Mar 24 '16 20:03 googlebot

@googlebot I signed it!

vivainio avatar Mar 24 '16 20:03 vivainio

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot avatar Mar 24 '16 20:03 googlebot

@vivainio This PR: https://github.com/angular/angular-electron/pull/10 will actually fix this as well :+1:

NathanWalker avatar Mar 26 '16 04:03 NathanWalker