angular-cli icon indicating copy to clipboard operation
angular-cli copied to clipboard

ng new my-project --skip-tests shouldn't generate karma/protractor files

Open StephenFluin opened this issue 7 years ago • 28 comments

The --skip-tests flag for ng new didn't quite match my expectations as a developer.

Versions

Angular CLI: 1.6.0-beta.0
Node: 8.4.0
OS: linux x64
Angular: 
...

Repro steps

ng new my-project --skip-tests

Observed behavior

  create my-project/.angular-cli.json (1528 bytes)
  create my-project/.editorconfig (245 bytes)
  create my-project/.gitignore (516 bytes)
  create my-project/src/assets/.gitkeep (0 bytes)
  create my-project/src/environments/environment.prod.ts (51 bytes)
  create my-project/src/environments/environment.ts (387 bytes)
  create my-project/src/favicon.ico (5430 bytes)
  create my-project/src/index.html (296 bytes)
  create my-project/src/main.ts (370 bytes)
  create my-project/src/polyfills.ts (2667 bytes)
  create my-project/src/styles.css (80 bytes)
  create my-project/src/test.ts (1085 bytes)
  create my-project/src/tsconfig.app.json (211 bytes)
  create my-project/src/tsconfig.spec.json (304 bytes)
  create my-project/src/typings.d.ts (104 bytes)
  create my-project/e2e/app.e2e-spec.ts (292 bytes)
  create my-project/e2e/app.po.ts (208 bytes)
  create my-project/e2e/tsconfig.e2e.json (235 bytes)
  create my-project/karma.conf.js (923 bytes)
  create my-project/package.json (1322 bytes)
  create my-project/protractor.conf.js (722 bytes)
  create my-project/tsconfig.json (363 bytes)
  create my-project/tslint.json (2985 bytes)
  create my-project/src/app/app.module.ts (316 bytes)
  create my-project/src/app/app.component.css (0 bytes)
  create my-project/src/app/app.component.html (1120 bytes)
  create my-project/src/app/app.component.ts (207 bytes)

Desired behavior

  create my-project/.angular-cli.json (1528 bytes)
  create my-project/.editorconfig (245 bytes)
  create my-project/.gitignore (516 bytes)
  create my-project/src/assets/.gitkeep (0 bytes)
  create my-project/src/environments/environment.prod.ts (51 bytes)
  create my-project/src/environments/environment.ts (387 bytes)
  create my-project/src/favicon.ico (5430 bytes)
  create my-project/src/index.html (296 bytes)
  create my-project/src/main.ts (370 bytes)
  create my-project/src/polyfills.ts (2667 bytes)
  create my-project/src/styles.css (80 bytes)
  create my-project/src/tsconfig.app.json (211 bytes)
  create my-project/src/typings.d.ts (104 bytes)
  create my-project/package.json (1322 bytes)
  create my-project/tsconfig.json (363 bytes)
  create my-project/tslint.json (2985 bytes)
  create my-project/src/app/app.module.ts (316 bytes)
  create my-project/src/app/app.component.css (0 bytes)
  create my-project/src/app/app.component.html (1120 bytes)
  create my-project/src/app/app.component.ts (207 bytes)

StephenFluin avatar Jan 10 '18 22:01 StephenFluin

Completely agree with this. In my mind, Skipping tests removes anything to do with testing. Karma, E2E, spec files and configs (inside angular-cli.json), etc...

On the other hand, I also find it ridiculous the only option is to use -minimal which removes tslint/linting.

HunterMitchell avatar Jan 12 '18 06:01 HunterMitchell

Tested on release and beta versions, still having this problem.

ghost avatar Mar 06 '18 07:03 ghost

Tested with CLI 6.0.3. Testing setup is still being generated when using --skip-tests flag.

Angular CLI: 6.0.5
Node: 8.11.2
OS: darwin x64
Angular: 6.0.3

Would be really nice to have this feature covered in the next releases.

genov avatar May 27 '18 11:05 genov

Angular CLI 6.0.7 still the same.

# ng new test-app --minimal --skip-tests --dry-run
CREATE test-app/README.md (1024 bytes)
CREATE test-app/angular.json (4100 bytes)
CREATE test-app/package.json (1312 bytes)
CREATE test-app/tsconfig.json (384 bytes)
CREATE test-app/tslint.json (2805 bytes)
CREATE test-app/.editorconfig (245 bytes)
CREATE test-app/.gitignore (503 bytes)
CREATE test-app/src/environments/environment.prod.ts (51 bytes)
CREATE test-app/src/environments/environment.ts (631 bytes)
CREATE test-app/src/favicon.ico (5430 bytes)
CREATE test-app/src/index.html (294 bytes)
CREATE test-app/src/main.ts (370 bytes)
CREATE test-app/src/polyfills.ts (3194 bytes)
CREATE test-app/src/test.ts (642 bytes)
CREATE test-app/src/assets/.gitkeep (0 bytes)
CREATE test-app/src/styles.css (80 bytes)
CREATE test-app/src/browserslist (375 bytes)
CREATE test-app/src/karma.conf.js (964 bytes)
CREATE test-app/src/tsconfig.app.json (194 bytes)
CREATE test-app/src/tsconfig.spec.json (282 bytes)
CREATE test-app/src/tslint.json (314 bytes)
CREATE test-app/src/app/app.module.ts (314 bytes)
CREATE test-app/src/app/app.component.css (0 bytes)
CREATE test-app/src/app/app.component.html (1141 bytes)
CREATE test-app/src/app/app.component.ts (207 bytes)
CREATE test-app/e2e/protractor.conf.js (752 bytes)
CREATE test-app/e2e/src/app.e2e-spec.ts (304 bytes)
CREATE test-app/e2e/src/app.po.ts (208 bytes)
CREATE test-app/e2e/tsconfig.e2e.json (213 bytes)

NOTE: Run with "dry run" no changes were made.

SmallhillCZ avatar Jun 06 '18 08:06 SmallhillCZ

Tested with @angular/cli 6.0.8:

  1. --skip-tests still generated e2e files;
  2. --skip-e2e not work.

avinzheng avatar Jul 16 '18 02:07 avinzheng

Still an issue in 6.2.2

ghost avatar Sep 18 '18 21:09 ghost

Just a 'what if' -- for library development, I generally generate a new app and a single library - the app acting as the 'demo' for the library.

Generating without tests (including e2e) makes sense on the top level, but I do unit tests on the library. A lot of the libraries innards (karma, lint, etc..) extend the upper level, which would then be missing if these do go away.

Figured I'd share - maybe I should just start testing my demos :)

CharlyRipp avatar Nov 01 '18 19:11 CharlyRipp

In CLI v7.0.4 the --minimal flag is already working as expected. No generated test files. 👌

tojacob avatar Nov 04 '18 22:11 tojacob

In CLI v7.0.4 the --minimal flag is already working as expected. No generated test files.

It removes the test files, but also removes linting so it isn't really the right solution. The issue still remains that --skip-tests should remove ALL testing frameworks, not just unit tests

custompro12 avatar Mar 03 '19 16:03 custompro12

--minimal also forces the templates and styles to be inline

anantanandgupta avatar Apr 10 '19 02:04 anantanandgupta

Also, --minimal with --inlineTemplate and --inlineStyle set to false is not working.

techpavan avatar Apr 10 '19 06:04 techpavan

ng new my-project-no-test --minimal=true --routing=true --skip-tests=true see https://angular.io/cli/new

ha10id avatar Apr 12 '19 09:04 ha10id

ng new my-project-no-test --minimal=true --routing=true --skip-tests=true see https://angular.io/cli/new

See my comment above. The issue is the --minimal flag removes linting in addition to removing the testing frameworks. I think this would be fine, as that seems pretty minimal, however the flag's description only says it removes test frameworks and doesn't mention linting:

When true, creates a project without any testing frameworks.

To make things more flexible, there should probably be a --linting flag

custompro12 avatar Apr 12 '19 21:04 custompro12

ng new my-project-no-test --minimal=true --routing=true --skip-tests=true see https://angular.io/cli/new

See my comment above. The issue is the --minimal flag removes linting in addition to removing the testing frameworks. I think this would be fine, as that seems pretty minimal, however the flag's description only says it removes test frameworks and doesn't mention linting:

When true, creates a project without any testing frameworks.

To make things more flexible, there should probably be a --linting flag

Roger!

ha10id avatar Apr 15 '19 11:04 ha10id

You have to Use --skipTests

manojgohel avatar Aug 20 '20 04:08 manojgohel

Still a problem in 10.2

ErroneousFatality avatar Oct 29 '20 12:10 ErroneousFatality

This is expected as per description --skipTest doesn't generate .spec.ts files, but it still still adds the testing framework and it's config. If you want to create an application without any testing framework use --minimal.

More info: https://angular.io/cli/new

alan-agius4 avatar Oct 29 '20 12:10 alan-agius4

This is expected as per description --skipTest doesn't generate .spec.ts files, but it still still adds the testing framework and it's config. If you want to create an application without any testing framework use --minimal.

More info: https://angular.io/cli/new

The problem with using --minimal is that it enforces inline style and templating, and we don't want that. We just want an Angular project without testing.

ErroneousFatality avatar Oct 29 '20 12:10 ErroneousFatality

For anyone wanting to create an Angular project without test packages, files and configurations, I'll leave my conclusions: Using @angular/[email protected] Create a project using --skip-tests. Remove the following:

  • e2e folder
  • karma.conf.js
  • inside angular.json: the test and e2e configuration sections.
  • src/test.ts
  • Run npm uninstall @types/jasmine, @types/jasminewd2, jasmine-core, jasmine-spec-reporter, karma, karma-chrome-launcher, karma-coverage-istanbul-reporter, karma-jasmine, karma-jasmine-html-reporter, protractor

ErroneousFatality avatar Oct 29 '20 12:10 ErroneousFatality

why in angular.io is written --skip-tests and they didnt fix to --skipTests. they dont care?

Dewberrycat avatar Feb 06 '21 13:02 Dewberrycat

@Dewberrycat, the reason why is that camel cased arguments such as --skipTests are now deprecated and will be removed in the a future version.

alan-agius4 avatar Feb 06 '21 14:02 alan-agius4

@Dewberrycat, the reason why is that camel cased arguments such as --skipTests are now deprecated and will be removed in the a future version.

ok, --skip-tests also still doesnt work, what is wrong with angular team? do they remember where angular.io is? why they dont care about people, should we all be Nostradamuses to guess what to do?

Dewberrycat avatar Feb 06 '21 14:02 Dewberrycat

@Dewberrycat, the reason why is that camel cased arguments such as --skipTests are now deprecated and will be removed in the a future version.

The reason is not the issue. Out of date documentation is the issue.

ErroneousFatality avatar Feb 06 '21 14:02 ErroneousFatality

@Dewberrycat,

Can you elaborate on what’s the not correct in the docs about the skip test option?

In https://angular.io/cli/new the description of -skip-tests states the clearly what it does;

Do not generate "spec.ts" test files for the new project.

May I also remind you to keep the conversation constructive per the code of conduct. Thanks

@ErroneousFatality / @Dewberrycat this is an OSS project, feel free to create a PR to improve the docs if you find some parts are out of dated or incorrect. Such contributions would be greatly appreciated.

alan-agius4 avatar Feb 06 '21 14:02 alan-agius4

Update 2021 Angular V12

If you want to have the minimal mode and not have the inlineTemplate, I have done the following:

ng new test4 --minimal --inline-style = false (--inline-style = false didn't work)

But in the angular.json file I have looked for the inlineTemplate file and I have set it to false (it can be removed since it is false by default).

"@schematics/angular:component": {
          "inlineTemplate": false,
          "style": "scss",
          "skipTests": true
        },

However I think it is a mistake to set --inline-style = false and that it does not work the first time.

juanjinario avatar Jul 22 '21 14:07 juanjinario

How can this still be an issue 6 version later ?

ghost avatar Oct 28 '22 23:10 ghost

It still here

Pearseak avatar Feb 13 '23 09:02 Pearseak

Had some discussion about this today and we all agreed that ng new --skipTests should drop the test configuration.

With the work going on with Web Test Runner and Jest, we're planning to add something like ng new --test-runner jest|web-test-runner. We'll likely want to eventually replace --skipTests with --test-runner none to align with that flag.

One challenge with not generating tests is that it isn't clear how to add tests later if a user changes their mind for a project. We should look into some kind of ng generate karma-setup (eventually web-test-runner-setup and jest-setup as well) to add tests after project creation. That's not a strict blocker for fixing --skipTests behavior, since this is an existing problem today for users who manually delete tests after ng new or use ng new --minimal.

There was a recent PR for this in https://github.com/angular/angular-cli/pull/25901. We're likely a little too late to get this into version 17, but it's definitely something we can consider for v18.

dgp1130 avatar Nov 02 '23 00:11 dgp1130