angular-cli icon indicating copy to clipboard operation
angular-cli copied to clipboard

feat(@schematics/angular): use signal in app component

Open cexbrayat opened this issue 1 year ago • 1 comments

PR Checklist

Please check to confirm your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the new behavior?

Now that signals are recommended, this updates the generated AppComponent to use a signal for the title field.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

cexbrayat avatar Dec 11 '24 11:12 cexbrayat

@alan-agius4 @dgp1130 PR is ready for review with your feedback

cexbrayat avatar Jun 03 '25 22:06 cexbrayat

Thanks for the contribution, apologies for the long delay on this!

dgp1130 avatar Jun 06 '25 16:06 dgp1130

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.