angular-cli
angular-cli copied to clipboard
fix(@angular/cli): update regex to validate the project-name
fix(@angular/cli): update regex to validate the project-name
Ensure that the regex used for validating the project-name is updated to address any issues and enhance accuracy.
the existing regex for project-name validation was not validating the name with the dot(.) in application name.
Fixes #25704
PR Checklist
Please check to confirm your PR fulfills the following requirements:
- [x] The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:
What is the current behavior?
Issue Number: #25704
What is the new behavior?
Project name can include the dot(.) in the name while creating the project but while validating the dot(.) was missing. I updated the pattern to accept dot(.) in projectName.
Does this PR introduce a breaking change?
- [x] Yes
- [ ] No
Other information
Sure I will update it.
On Mon, 22 Jan 2024, 17:38 Alan Agius, @.***> wrote:
@.**** requested changes on this pull request.
Can you please update the commit message as per guideline https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines ?
Thanks
— Reply to this email directly, view it on GitHub https://github.com/angular/angular-cli/pull/26909#pullrequestreview-1836319254, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQOKR2AZXSFJQRLQNWTXB6TYPZJDRAVCNFSM6AAAAABCDCRUVKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMZWGMYTSMRVGQ . You are receiving this because you authored the thread.Message ID: @.***>
@alan-agius4 I have updated the commit message. Can you please review it?
Looks like you updated the PR description and not the commit message. Also, the scope should be @angular/cli
and not @angular-cli
.
Looks like you updated the PR description and not the commit message. Also, the scope should be
@angular/cli
and not@angular-cli
.
I have updated the commit fixing the typo.
The commit message has not been updated.
@alan-agius4 I have updated the commit as well please check.
Can you please squash into a single commit? Otherwise it should be good.
Can it be merged now?
@alan-agius4 i closing this PR and have raised a new PR #26924. Please check and review it.
This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.