angular-cli icon indicating copy to clipboard operation
angular-cli copied to clipboard

[FIX] Updated regex for the application name to not accept "."

Open harshlakhara opened this issue 1 year ago • 1 comments

fix(@angular-cli): Updated the regex to invalidate the application name with "." in it. As the validation for project name doesn't accept "." in the name and thorows the error: "Data path "/projects" must NOT have additional properties(xyx.com)"

PR Checklist

Please check to confirm your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: #25704

What is the new behavior?

After the fix user creating new project will not be allowed to enter "." in the name of the application. i.e. xyz.com will get invalidated.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

harshlakhara avatar Jan 20 '24 09:01 harshlakhara

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jan 20 '24 09:01 google-cla[bot]

Let go with https://github.com/angular/angular-cli/pull/26909 as dots are fine.

alan-agius4 avatar Jan 22 '24 12:01 alan-agius4

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.