angular-cli icon indicating copy to clipboard operation
angular-cli copied to clipboard

fix(@angular/cli): add builders and schematic names as page titles in collected analytics

Open alan-agius4 opened this issue 3 years ago • 2 comments

With this commit the builder and schematic names are added as page title to page events.

Also, we address a bug where during a watch or error in some cases analytics where not flushed. Examples when the builder has a watch mode.

Screenshot 2022-08-10 at 11 25 11

alan-agius4 avatar Aug 10 '22 09:08 alan-agius4

Currently figuring out the privacy approval process for this change, so don't merge this just yet.

dgp1130 avatar Aug 11 '22 00:08 dgp1130

I just realized we also list out the data collected on AIO: https://angular.io/analytics#what-is-collected. We should update that as well when this is ready to land.

dgp1130 avatar Aug 19 '22 18:08 dgp1130

This is fully privacy approved, so we're good to merge this in and release: http://launch/4185851.

Don't forget to update https://angular.io/analytics#what-is-collected, whether in this PR or another one.

dgp1130 avatar Sep 22 '22 21:09 dgp1130

This is fully privacy approved, so we're good to merge this in and release: http://launch/4185851.

Don't forget to update https://angular.io/analytics#what-is-collected, whether in this PR or another one.

Awesome. Has to be a separate PR as it's a different repo.


EDIT: https://github.com/angular/angular/pull/47529

alan-agius4 avatar Sep 23 '22 07:09 alan-agius4

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.