ui-sortable icon indicating copy to clipboard operation
ui-sortable copied to clipboard

make CI build faster

Open PeterDaveHello opened this issue 10 years ago • 7 comments

PeterDaveHello avatar Aug 25 '14 16:08 PeterDaveHello

Coverage Status

Coverage remained the same when pulling 33b1f5b4db382796ea164cbb378558df4673cb82 on PeterDaveHello:patch-1 into d21f53228d039f5575facc4b9a180606098951d0 on angular-ui:master.

coveralls avatar Aug 25 '14 16:08 coveralls

With the current size of the repo, I didn't see any gains comparing this PR's build time and for example the svg PR??

thgreasi avatar Aug 25 '14 19:08 thgreasi

Because the deviation range is very big, but it can still help, just like we don't need the whole repo to CI build, do use git shallow clone, the default value of depth is 50 on travis CI, but usually we don't need so many revisions to build, a lower number can help to save the bandwidth and time.

PeterDaveHello avatar Aug 26 '14 00:08 PeterDaveHello

The merging of v0.13.x-dev branch into master contained more than 20 commits, would that be a problem with this PR? Also, while searching Github I found that some repos have reverted their explicit git setting.

thgreasi avatar Oct 17 '14 16:10 thgreasi

I think that won't be a problem.

PeterDaveHello avatar Oct 17 '14 16:10 PeterDaveHello

I will be honest... I'm afraid enough to not merge this. I appreciate your commit and plan to rebase it after each major release of ui-sortable. At the point that the CI build gets faster, I will reopen and merge it.

thgreasi avatar Oct 17 '14 17:10 thgreasi

No problem.

PeterDaveHello avatar Oct 18 '14 02:10 PeterDaveHello