ui-select icon indicating copy to clipboard operation
ui-select copied to clipboard

fix(autofocus): check for truthy attribute

Open brianchance opened this issue 7 years ago • 7 comments

For #1951

brianchance avatar Apr 14 '17 14:04 brianchance

okay agree, could you have a look at the tests?

Jefiozie avatar Oct 09 '17 05:10 Jefiozie

The test details are about the header and footer, not the autofocus. When I run the tests locally, I get success across the board. Will try to re-trigger the travis-ci

brianchance avatar Oct 09 '17 14:10 brianchance

I pulled the latest, not sure what the issue is, but it is the describe('Header & Footer' tests that are failing, not the autofocus tests.

It seems to me that the header and footer templates were removed in the merge from you repo.

brianchance avatar Oct 09 '17 15:10 brianchance

Hi @brianchance could you merge the master in your branch and see if the issue is fixed? Thanks

Jefiozie avatar Oct 15 '17 17:10 Jefiozie

I have merged with the main branch. I am still unsure of what happened here.

When someone (you?) merged into my branch - 3cca75a79e5f89a6011a0264b37e9f5be2405baf, it removed the header and footer directive but not the tests for the header and footer. My final commit removes those tests.

If 3cca75a79e5f89a6011a0264b37e9f5be2405baf was not supposed to be merged, I can work to get rid of it.

brianchance avatar Oct 20 '17 13:10 brianchance

@brianchance Hi, is there any updates on this?

nasvillanueva avatar Jun 07 '18 06:06 nasvillanueva

@nasvillanueva Nope.

brianchance avatar Jun 07 '18 12:06 brianchance