ui-leaflet icon indicating copy to clipboard operation
ui-leaflet copied to clipboard

Destroying scope should only remove its own defaults

Open eugenehuangsg opened this issue 7 years ago • 2 comments

Dynamically instantiated maps's defaults are removed when other maps are removed. eg. using ng-if to toggle displaying of different tabs.

eugenehuangsg avatar Aug 07 '17 03:08 eugenehuangsg

Similar implementation to https://github.com/angular-ui/ui-leaflet/pull/322

npm test runs well locally. Build error is probably due to one of the package.json dependencies. I'm still unable to isolate which dependencies is causing the problem. https://github.com/angular-ui/ui-leaflet/issues/347

eugenehuangsg avatar Aug 07 '17 06:08 eugenehuangsg

Please check this commit, https://github.com/angular-ui/ui-leaflet/commit/fee0175b68d9a754a46196d81173e360c5a97fbf,

all efforts will be focused on the version for Leaflet 1.x

Thanks.

elesdoar avatar Nov 17 '17 13:11 elesdoar