ui-leaflet-draw icon indicating copy to clipboard operation
ui-leaflet-draw copied to clipboard
verified publisher icon angular-ui

Github dependency

Open umdstu opened this issue 7 years ago • 3 comments

Is there still a reason this package needs to be dependent on github:

"leaflet-draw": "git://github.com/michaelguild13/Leaflet.draw.git#master",

instead of Leaflet.Draw since it's in NPM ?

umdstu avatar May 24 '18 15:05 umdstu

Probably not, feel free to submit a PR.

nmccready avatar May 24 '18 18:05 nmccready

Seems simple enough, but since this is currently pointing to something several years old (and several hundred commits behind /Leaflet/Leaflet.draw, what are the chances of this working with the 'current' version of Leaflet.draw?

umdstu avatar May 28 '18 04:05 umdstu

I don't really have any idea. I don't really have time to commit to that right now. I would assume it would not.

Also the repo git://github.com/michaelguild13/Leaflet.draw.git#master is a fork by @michaelguild13 which did not seem to be published to NPM . The reason for pointing to that fork; was at the time he was the only one that supported touch screens correctly. I would hope that this has been resolved by now .

nmccready avatar May 29 '18 17:05 nmccready