ui-layout icon indicating copy to clipboard operation
ui-layout copied to clipboard

After moving the splitter toggle to expand left column to maximum is not working

Open saharj opened this issue 9 years ago • 8 comments
trafficstars

Here is my HTML:

  <div ui-layout="{ flow : 'column', dividerSize: '8px'}">
    <div class="editor pane" ui-layout-container>
      <div ui-view="editor"></div>
    </div>
    <div class="preview pane" ui-layout-container>
      <div ui-view="preview"></div>
    </div>
  </div>

giphy

Surprisingly it does work for the right panel!

You can try it live at http://editor.swagger.io. You'll need to move the splitter a little before toggling to get the error.

saharj avatar May 07 '16 21:05 saharj

+1 The same happens in @widmoser's plunker in #162

artigi avatar Jun 03 '16 13:06 artigi

It looks like the Holy grail demo (ui-layout v1.0.5) doesn't have this issue.

artigi avatar Jun 17 '16 19:06 artigi

In ui-layout v1.0.5, you will not get this issue and also it will not support ng-repeat. You can try ui-layout v1.3.1 it will support both.

alagarrk avatar Jun 28 '16 10:06 alagarrk

Anyone take the time to see what the diff between the two versions (and subsequent versions) were that caused the break?

umdstu avatar Jun 30 '16 17:06 umdstu

+1, this is breaking for me too, you can repro by just clicking on the different toggles several times. I This seems to be broken in 1.4.0, 1.4.1, and 1.4.2

I reverted back to 1.3.1 and it works

dliu120 avatar Aug 06 '16 00:08 dliu120

Looks like someone found a solution here Problem still open with 1.4.3. Reproduction case demo/demo4.html with Chrome play a little with the toggle buttons and you will see the problem. Looks like someone found a solution here (it is not me) http://stackoverflow.com/questions/34310279/angular-ui-layout-toggle-not-working I will PR this fix.

bpatra avatar Mar 15 '17 12:03 bpatra

+1

zoyun avatar Apr 13 '17 06:04 zoyun

calculate issue when the afterbutton click. the root cause due to do not update the uncollapsedSize of prevContainer when toggleAfter. I have created a pull request for this bug fix. #228

zoyun avatar Apr 13 '17 06:04 zoyun