bootstrap icon indicating copy to clipboard operation
bootstrap copied to clipboard

'dateDisabled' validation error is pushed to the form and not the element

Open shysank opened this issue 8 years ago • 5 comments

The issues forum is NOT for support requests. It is for bugs and feature requests only. Please read https://github.com/angular-ui/bootstrap/blob/master/CONTRIBUTING.md and search existing issues (both open and closed) prior to opening any new issue and ensure you follow the instructions therein.

Bug description:

When a disabled date is chosen by typing in, the 'dateDisabled' validation error is triggered. However the validation error object is pushed to '$error' in the form and not the element. This makes it difficult to differentiate the errors if there are more than one datepickers.

Link to minimally-working plunker that reproduces the issue:

https://plnkr.co/edit/0XWmsZEo1BF3fU7NJgnA?p=preview

Version of Angular, UIBS, and Bootstrap

Angular: 1.5.8

UIBS: 2.2.0

Bootstrap: 3.3.7

shysank avatar Nov 22 '16 17:11 shysank

+1

appienvanveen avatar Dec 08 '16 14:12 appienvanveen

file: datepicker.js line: 214

      ngModelCtrl.$setValidity('dateDisabled', !date ||
        this.element && !this.isDisabled(date));

gpcaretti avatar Jun 09 '17 14:06 gpcaretti

Any progress at this issue ?

MatthiasGwiozda avatar Dec 26 '17 09:12 MatthiasGwiozda

Any progress at this issue ?

andrefarzat avatar Feb 27 '18 00:02 andrefarzat

Hey all,

I got super frustrated by how bad the validation was on this thing, so I rolled my own directive which seems to do the job, at least for my purposes. Just add valid-date to your input. See this gist for the code. Note, I use moment to compare the dates correctly.

Hope that helps some peeps.

benmccallum avatar Jul 19 '18 19:07 benmccallum