angular-google-maps icon indicating copy to clipboard operation
angular-google-maps copied to clipboard

Feature request: Typescript definitions

Open grantfeldman opened this issue 10 years ago • 17 comments

Are there any typescript definitions available for this library?

grantfeldman avatar Jun 17 '14 23:06 grantfeldman

no and there are no plans. Microsoft is not on the radar.

nmccready avatar Jun 18 '14 00:06 nmccready

Seems like people from Angular Project are thinking different http://www.itworld.com/article/2894936/googles-angular-2-being-built-with-microsofts-typescript.html

danielmariz avatar May 29 '15 05:05 danielmariz

@danielmariz notice this was 12 months ago. Well before angular had that on the road map.

cthrax avatar May 29 '15 05:05 cthrax

so now do you have ts definitions available?

danielmariz avatar May 29 '15 05:05 danielmariz

No. But it would be welcome now as a PR.

cthrax avatar May 29 '15 05:05 cthrax

+1

maruf89 avatar Sep 04 '15 16:09 maruf89

Ugh well this was decided way before Angular / Google decided to go with TypeScript. I will consider it, but someone else needs to lead the way and start a small PR. Then I can follow in. +1's are not welcomed as it benefits no one.

If you want it done and done fast then contribute.

nmccready avatar Sep 04 '15 18:09 nmccready

Re-opening

nmccready avatar Sep 04 '15 18:09 nmccready

Also note if more people start +1 I will lock the issue. Give meaningful feedback like directions and design ideas instead.

nmccready avatar Sep 04 '15 18:09 nmccready

Possible guide on getting up to speed on tsd http://definitelytyped.org/guides/creating.html

nmccready avatar Sep 04 '15 18:09 nmccready

I think someone can come up with TypeScript Definition for this library.

piyushchauhan2011 avatar Oct 14 '15 05:10 piyushchauhan2011

I will accept a PR; but I have no plans on working on this.

nmccready avatar Oct 14 '15 13:10 nmccready

Is anyone working on a Typescript Definition?

If not I am going to start one as I need it for my current project, then I will publish to DefinitelyTyped once done and tested in anger.

testpossessed avatar Mar 07 '16 13:03 testpossessed

@testpossessed i think your "it"

nmccready avatar Mar 07 '16 14:03 nmccready

FYI there are already 2 google maps definition entries you could use or leverage

  • https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/google-maps
  • https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/googlemaps

grantfeldman avatar Mar 07 '16 21:03 grantfeldman

I have the first of these definitions loaded, but of course it is not being matched by the tools because there is nothing declaring that the angular component is returning these types.

On initial look it seems there is little angular-google-maps specific that needs to be declared other than the script loader and api, the rest of of the objects exposed are google-maps specific, but this is just an initial look I may be wrong and find more as I work through it.

testpossessed avatar Mar 08 '16 07:03 testpossessed

@testpossessed did you end up solving this?

jpike88 avatar Apr 21 '18 05:04 jpike88