angularjs-slider icon indicating copy to clipboard operation
angularjs-slider copied to clipboard

Change ticks-values positioning by using bottom instead of top

Open ValentinH opened this issue 9 years ago • 13 comments

Currently, top: Xpx is used for horizontal sliders, but it would be better to use bottom so the alignement remains the same for different font sizes.

ValentinH avatar Nov 22 '16 16:11 ValentinH

also interested in this

upeshdesai avatar Dec 01 '16 22:12 upeshdesai

Hi can I take this up @ValentinH ?

Kashyap12 avatar Mar 06 '17 14:03 Kashyap12

Sure! Do you know from where to start?

ValentinH avatar Mar 06 '17 14:03 ValentinH

No , I am quite new to OS projetcs

Kashyap12 avatar Mar 06 '17 14:03 Kashyap12

For this issue, you only need to update the rzslider.less file. Before starting, you should read the CONTRIBUTING.md one.

ValentinH avatar Mar 06 '17 14:03 ValentinH

The goal is to get the exact same rendering than the current version. So while developing the change, you should compare with the demo website: http://angular-slider.github.io/angularjs-slider/

ValentinH avatar Mar 06 '17 14:03 ValentinH

ok , thanks @ValentinH , will start now

Kashyap12 avatar Mar 06 '17 14:03 Kashyap12

Then to display your changes, you need to open the demo/index.html file in a browser.

ValentinH avatar Mar 06 '17 14:03 ValentinH

Finally, when submitting the pull request, please provide a JSFiddle running your fork version that show that everything works.

You can fork this one: http://jsfiddle.net/cwhgLcjv/ and update the library import:

<script src="https://rawgit.com/rzajac/angularjs-slider/master/dist/rzslider.js"></script>

by replacing rzajac by your username.

ValentinH avatar Mar 06 '17 14:03 ValentinH

Basically like it was done in #505

ValentinH avatar Mar 06 '17 14:03 ValentinH

Cool @ValentinH

Kashyap12 avatar Mar 06 '17 14:03 Kashyap12

Hello @ValentinH, I see this issue is still open, can I take it up?

karolinanovaksolanska avatar Sep 30 '17 14:09 karolinanovaksolanska

Yes sure :)

ValentinH avatar Oct 01 '17 07:10 ValentinH