angularjs-slider
angularjs-slider copied to clipboard
Change ticks-values positioning by using bottom instead of top
Currently, top: Xpx is used for horizontal sliders, but it would be better to use bottom so the alignement remains the same for different font sizes.
also interested in this
Hi can I take this up @ValentinH ?
Sure! Do you know from where to start?
No , I am quite new to OS projetcs
For this issue, you only need to update the rzslider.less file. Before starting, you should read the CONTRIBUTING.md one.
The goal is to get the exact same rendering than the current version. So while developing the change, you should compare with the demo website: http://angular-slider.github.io/angularjs-slider/
ok , thanks @ValentinH , will start now
Then to display your changes, you need to open the demo/index.html file in a browser.
Finally, when submitting the pull request, please provide a JSFiddle running your fork version that show that everything works.
You can fork this one: http://jsfiddle.net/cwhgLcjv/ and update the library import:
<script src="https://rawgit.com/rzajac/angularjs-slider/master/dist/rzslider.js"></script>
by replacing rzajac by your username.
Basically like it was done in #505
Cool @ValentinH
Hello @ValentinH, I see this issue is still open, can I take it up?
Yes sure :)