angular-cli-ghpages icon indicating copy to clipboard operation
angular-cli-ghpages copied to clipboard

add dest and add option to cli

Open Hypercubed opened this issue 2 years ago • 5 comments

Please consider adding the dest and add options to the cli.

Hypercubed avatar Apr 08 '22 18:04 Hypercubed

Thank you very much for pushing this feature. I will review this on Monday! 🙂👍

JohannesHoppe avatar Apr 09 '22 07:04 JohannesHoppe

@JohannesHoppe Anything you need from me?

Hypercubed avatar May 20 '22 19:05 Hypercubed

@Hypercubed Thanks for your patience! Lots of things going on here at the moment … Thanks for your contribution which I think makes sense. The only thing that's missing is documentation. Can you please add the new options to the Standalone README? That will help a lot!

fmalcher avatar Jun 17 '22 07:06 fmalcher

One thing that's still open for discussion: You only added the options to the standalone variant. I think we should also make them available for the Angular CLI builder. Is there any reason why we should NOT do this?

  • Extend the Schema: https://github.com/angular-schule/angular-cli-ghpages/blob/master/src/deploy/schema.json
  • check whether the options will be considered from both the command line and the config file
  • extend the docs (README.md)

fmalcher avatar Jun 17 '22 07:06 fmalcher

yes, I actually don't need this feature, but there would certainly be a good usecase. However, it needs to be well documented so that people don't get confused with dist and dest.

JohannesHoppe avatar Jun 17 '22 21:06 JohannesHoppe

I added a --dir option in [email protected]. Please try out this version and give me feedback.

This option overrides the directory for all published sources, relative to the current working directory. The normal logic with buildTargets and conventions is ignored in this case.

See https://github.com/angular-schule/angular-cli-ghpages/pull/179

Do you still need dest and add, if yes, please comment here so that I can reopen this issue! 👍

JohannesHoppe avatar Jan 26 '24 15:01 JohannesHoppe