angular-hub
angular-hub copied to clipboard
feat(content): added upcoming events for ngGirls to community.json
PR Checklist
Please check if your PR fulfills the following requirements:
- [x] The commit message follows our guidelines: https://github.com/ngneat/transloco/blob/master/CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
- [ ] Bugfix
- [x] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
- [ ] Yes
- [x] No
Other information
thank you @geromegrignon for making it so easy to contribute
Deploy Preview for angular-hub ready!
| Name | Link |
|---|---|
| Latest commit | 127581e493b319f4905131548f5887ae5917e77f |
| Latest deploy log | https://app.netlify.com/sites/angular-hub/deploys/681ee6f7ae7e6400082091d8 |
| Deploy Preview | https://deploy-preview-405--angular-hub.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@esthersoftwaredev is it possible to add the Bluesky link https://bsky.app/profile/angulargirls.bsky.social and X link https://x.com/AngularGirls as well?
@esthersoftwaredev is it possible to add the Bluesky link https://bsky.app/profile/angulargirls.bsky.social and X link https://x.com/AngularGirls as well?
cool of course thank you for providing the links
@geromegrignon after reading @LoganDupont's comment I went to add the links and this is when I noticed that ngGirls is actually in the .json file already, but they do not appear on the site.
It is a bit late today but tomorrow I will correct the unnecessary addition and I will just list the most current events that they have instead of listing them again.
The reason they don't appear is because they are listed as "type": "workshop" there are two listed under this type, "Angular Training" & "ngGirls" and neither of them appears on https://angular-hub.com/communities
@esthersoftwaredev i'll think about how to handle it: Angular training was added due to a free workshop, but not a community and used it as a nave way to filter info.
@esthersoftwaredev @geromegrignon Did a rework of the website and now you should be able to see "ngGirls". So in the future you can just create a PR if there are new workshops.
@esthersoftwaredev @geromegrignon Did a rework of the website and now you should be able to see "ngGirls". So in the future you can just create a PR if there are new workshops.
That's great, thank you :)